Announcement

Collapse
No announcement yet.

Garbage code in Search Results image tags if Resize Image is unchecked.

Collapse
X
  • Filter
  • Time
  • Show
Clear All
new posts

  • Garbage code in Search Results image tags if Resize Image is unchecked.

    Seen on 18.0.2 and 18.0.3. And all V16 and earlier.

    Take a standard site and go to Settings / Search And Filtering Settings / Results and uncheck Resize Image.
    Upload site and search for "ring".
    Inspect the image from one of the results and you'll see e.g.
    Code:
    <img src="s-Wedding-Rings.jpg" title="Wedding&#32;Rings" s-Wedding-Rings.jpgSIZE border="0"/>
    I've marked the garbage in red.

    This looks like <actinic:variable name="SearchResultProductImageSize" /> is being badly parsed by the Perl scripts.

    YASB!
    Norman - www.drillpine.biz
    Edinburgh, U K / Bitez, Turkey

  • #2
    Thanks Norman. How on earth did you spot that?! The problem seems symptomless in the browser, but I've raised a ticket for it, SD-7635
    Bruce Townsend
    Ecommerce Product Manager
    Sellerdeck Ecommerce Solutions

    Comment


    • #3
      I was inspecting the search results image on a clients site to see if it could have a different size from the filtered pages. Noticed the garbage. I'd have expected an HTML validator to notice an invalid attribute.

      P.S. You can have fun with this. Consider an image called "hidden .jpg" (note the space before .jpg).
      This will lead to an image tag like <img src="hidden .jpg" title="Engagement Ring" hidden .jpgsize border="0"> and that hidden is now a valid attribute and will hide the image.

      Or, more scary, try image called onclick=alert('gotcha') .jpg
      Norman - www.drillpine.biz
      Edinburgh, U K / Bitez, Turkey

      Comment


      • #4
        Point taken...
        Bruce Townsend
        Ecommerce Product Manager
        Sellerdeck Ecommerce Solutions

        Comment

        Working...
        X