Dynamic Price Layout - Broken 12.0.1?

[mediamole]

Hi Guys,

I've upgrade a site to 12.0.1

The product layout then broke. On investigating I noted a broken block if statement at the bottom of the Dynamic Price Layout.

Has anyone else experienced this? Or maybe just my code and just me?

				</actinic:block>
			</actinic:block>							
		</div>
	</actinic:block> <-- end one appears broken on line 55

[Southwest Test]

Hi Garry,

I upgraded to 12.0.1 last night - I've had a look at the code you refer to and can confirm line 55 is exactly the same in my software as the code you've highlighted

Lines 52 and 53 are not though... they are in my case both simply:

/block
/block

[mediamole]

Just to confirm you say you've got a broken block if too?

see attached image. Line 55 the block if now broken since upgrade on the site i had to test

[Southwest Test]

Yes, the code in your second image matches mine exactly

[mediamole]

Oh right. Looks like potential upgrade issue then. As that BLOCK IF statement is broken.

[guccij]

Is that what is causing this when seen online (not in preview):

[mediamole]

Appears to the overall wrapper BLOCK IF statement that has broken.

If look at source code it's showing the Dynamic Price code now despite not being enabled.

Whereby it's showing the code for Dynamic Price whether you use it or not.

[mediamole]

Might not be overall wrapper broken as just created a new IF BLOCK and then wrapped the rest of code in it, and the issue still occurs.

I think might just be </actinic:block> is an extra closing statement and the closing DIV needs to go above last if block.

I'd wait for an official fix though if that is the case.

[mediamole]

Appears the broken BLOCK IF is just a bit of duplicate code of bottom.

IMPORTANT
Below worked for me, but if try it, please make a backup of site first. And if you're unsure I'd recommend you contact support directly for assistance as NOT officially declared as a bug!

Also. it will depend on the theme you're using whether it's bespoke or a standard theme. Therefore, I'd not use the code below unless you're 100% sure that's the issue you have and you're confident with making the fix.

Simply replace ALL the code in Dynamic Price Layout with below.

	<actinic:block if="%3cactinic%3avariable%20name%3d%22UseDynamicPrices%22%20%2f%3e%20AND%20%3cactinic%3avariable%20name%3d%22ProductPriceIsEnabled%22%20%2f%3e" >
		<div id="id<actinic:variable name="ProductID" />DynamicPrice" <actinic:block if="%28%3cactinic%3avariable%20name%3d%22IsPreviewMode%22%20%2f%3e%20%3d%3d%20false%29%20OR%20%28%3cactinic%3avariable%20name%3d%22OverrideStaticPrice%22%20%2f%3e%20%3d%3d%20true%29" >style="display: none"</actinic:block>>		
				<actinic:block if="%3cactinic%3avariable%20name%3d%22IsPreviewMode%22%20%2f%3e%20%3d%3d%20true%20AND%20%28%3cactinic%3avariable%20name%3d%22PageType%22%20%2f%3e%20%3d%3d%20%22Section%22%20OR%20%3cactinic%3avariable%20name%3d%22PageType%22%20%2f%3e%20%3d%3d%20%22Product%20Page%22%29" >
					<actinic:variable name="DynamicPricePrefix" />&nbsp;&lt;price here&gt;
				</actinic:block>
				<actinic:block if="%3cactinic%3avariable%20name%3d%22IsPreviewMode%22%20%2f%3e%20%3d%3d%20false" >
				<actinic:block if="%3cactinic%3avariable%20name%3d%22OverrideStaticPrice%22%20%2f%3e%20%3d%3d%20false"><actinic:variable name="DynamicPricePrefix" /></actinic:block><actinic:block if="%3cactinic%3avariable%20name%3d%22OverrideStaticPrice%22%20%2f%3e%20%3d%3d%20true" ><actinic:variable name="ProductPriceDescription" /></actinic:block>&nbsp;
					<actinic:block PHP='true' SELECTABLE='false'>
					if (!isset($g_bShowDynamicTaxInclusivePrice))
						{
						$g_bShowDynamicTaxInclusivePrice = false;
						}
					if (!isset($g_bShowDynamicTaxMessage))
						{
						$g_bShowDynamicTaxMessage = false;
						}
					if (!isset($g_bShowDynamicTaxExclusivePrice))
						{
						$g_bShowDynamicTaxExclusivePrice = false;
						}
					if ($g_bShowDynamicTaxInclusivePrice && !$g_bShowDynamicTaxExclusivePrice) 
						{
						echo '<span id="id<actinic:variable name="ProductID" />TaxIncPrice"></span>';
						if ($g_bShowDynamicTaxMessage)
							{
							echo '<actinic:block if="%3cactinic%3avariable%20name%3d%22TaxName1%22%20%2f%3e%20%21%3d%20%22%22%20OR%20%3cactinic%3avariable%20name%3d%22TaxName2%22%20%2f%3e%20%21%3d%20%22%22" >	
									<span id="id<actinic:variable name="ProductID" />VATMsg" class="actxxsmall">&nbsp;(Including <actinic:block if="TaxName1%20%21%3d%20%22%22" ><actinic:variable name="TaxName1"/> at <actinic:variable name="TaxRate1"/>%</actinic:block><actinic:block if="%3cactinic%3avariable%20name%3d%22TaxName1%22%20%2f%3e%20%21%3d%20%22%22%20AND%20%3cactinic%3avariable%20name%3d%22TaxName2%22%20%2f%3e%20%21%3d%20%22%22" > and </actinic:block><actinic:block if="%3cactinic%3avariable%20name%3d%22TaxName2%22%20%2f%3e%20%21%3d%20%22%22" ><actinic:variable name="TaxName2"/> at <actinic:variable Name="TaxRate2"/>%</actinic:block>)
									</span> 
									</actinic:block>';
							}
						}
					if (!$g_bShowDynamicTaxInclusivePrice && $g_bShowDynamicTaxExclusivePrice)
						{
						echo '<span id="id<actinic:variable name="ProductID" />TaxExcPrice"></span>
								<actinic:block if="%3cactinic%3avariable%20name%3d%22TaxName1%22%20%2f%3e%20%21%3d%20%22%22%20OR%20%3cactinic%3avariable%20name%3d%22TaxName2%22%20%2f%3e%20%21%3d%20%22%22" >	
									<span id="id<actinic:variable name="ProductID" />VATMsg" class="actxxsmall">&nbsp;(Excluding <actinic:block if="TaxName1%20%21%3d%20%22%22" ><actinic:variable name="TaxName1"/> at <actinic:variable name="TaxRate1"/>%</actinic:block><actinic:block if="%3cactinic%3avariable%20name%3d%22TaxName1%22%20%2f%3e%20%21%3d%20%22%22%20AND%20%3cactinic%3avariable%20name%3d%22TaxName2%22%20%2f%3e%20%21%3d%20%22%22" > and </actinic:block><actinic:block if="%3cactinic%3avariable%20name%3d%22TaxName2%22%20%2f%3e%20%21%3d%20%22%22" ><actinic:variable name="TaxName2"/> at <actinic:variable Name="TaxRate2"/>%</actinic:block>)</span>
								</actinic:block>';
						}
					if ($g_bShowDynamicTaxInclusivePrice && $g_bShowDynamicTaxExclusivePrice)
						{
						echo '<span id="id<actinic:variable name="ProductID" />TaxExcPrice"></span>
							<actinic:block if="%3cactinic%3avariable%20name%3d%22TaxName1%22%20%2f%3e%20%21%3d%20%22%22%20OR%20%3cactinic%3avariable%20name%3d%22TaxName2%22%20%2f%3e%20%21%3d%20%22%22" >	
								<span id="id<actinic:variable name="ProductID" />VATMsg" class="actxxsmall">
									(<span id="id<actinic:variable name="ProductID" />TaxIncPrice"></span> Including <actinic:block if="TaxName1%20%21%3d%20%22%22" ><actinic:variable name="TaxName1"/> at <actinic:variable name="TaxRate1"/>%</actinic:block><actinic:block if="%3cactinic%3avariable%20name%3d%22TaxName1%22%20%2f%3e%20%21%3d%20%22%22%20AND%20%3cactinic%3avariable%20name%3d%22TaxName2%22%20%2f%3e%20%21%3d%20%22%22" > and </actinic:block><actinic:block if="%3cactinic%3avariable%20name%3d%22TaxName2%22%20%2f%3e%20%21%3d%20%22%22" ><actinic:variable name="TaxName2"/> at <actinic:variable Name="TaxRate2"/>%</actinic:block>)
								</span>
								</actinic:block>';
						}
					unset($g_bShowDynamicTaxInclusivePrice);
					unset($g_bShowDynamicTaxMessage);
					unset($g_bShowDynamicTaxExclusivePrice);
				</actinic:block>	
				</actinic:block>
				</div>
			</actinic:block>

[guccij]

I've also got issues with the product layout width now.

Going to uninstall and reinstall.

[mediamole]

When do you get the issue? Before or after adding the code I pasted?

[guccij]

I've just changed the layout to your new code and the issue has gone, so thank you for spotting the problem so quickly and providing a solution to it

Pretty bloody shoddy work for a production release imo

[pmsupport]

Hi Garry,

I can see you have raised a ticket with support for this issue. This is being investigated, thanks for raising the issue.

Thanks

Paul

[mediamole]

No worries.

The basic issue being that the broken BLOCK IF will add an extra </div> tag and potentially break product pages (depending on how they've been coded)

[brucet]

What version did you upgrade from, please? I will check it out