PHP Parse Error Inside Actinic Not On The Web

[SpecTech]

Hi,

I built a system a while ago that gets the rrp and price and then using this information gives you a how much you save and percentage, now I use this on all our sites and it seems to work perfectly however using the same code ive used on all our actinic sites it seems to give me an error on this one site :s. however it looks fine once I preview on website here is my code:

<actinic:block php="true" >
$rrp = <actinic:variable name="Product RRP" selectable="false" />;
$rawprice = <actinic:variable name="ProductPriceRaw" selectable="false" />;
{
$amountsaved = ($rrp - $rawprice);
$savepercent = ((($rrp - $rawprice) / $rrp) * 100);
echo "you save £$amountsaved";
echo " (".number_format($savepercent,1);
echo "%)";
}
</actinic:block>

what is odd is as soon as I replace the variable Product RRP with the number that I am inputting into the variable the error goes away meaning it is somthing to do with this variable :s

Simon

[NormanRouxel]

Make sure that variable Product RRP is of type number and that you don't allow empty values.

Also, I see that if RRP is ever 0 you will cause a divide by zero error.

It may be a good idea to have a Condition around all this that checks that Product RRP > 0 and also that Product RRP > ProductPriceRaw.

[SpecTech]

Hi Norman, thanks for the reply it is already wrapped in a condition which I did not include. where the variable rrp needs to be over 1 for this to take effect. I have also double checked the variable settings and they are set up as you say. I am totally confused to why it is doing this :s

[NormanRouxel]

Remove the line

<actinic:block php="true" >

and the ending

</actinic:block>

You'll then be able to see what PHP is seeing and eyeball parse it.

[SpecTech]

It looks fine to me, this is what it looks like without the php block,

$rrpprice = 49.99; $price = 39.99; { $amountsaved = ($rrpprice - $price); $savepercent = ((($rrpprice - $price) / $rrpprice) * 100); echo "you save £$amountsaved"; echo " (".number_format($savepercent,1); echo "%)"; }

apart from there being no breaks inbetween the lines it looks fine :s

[NormanRouxel]

Put the blocks back. Then try adding

encoding="perl"

to each variable.

[SpecTech]

ok I tryed that and still the same error :s here is the code with the added blocks with the perl true inside:

<actinic:block if="%3cactinic%3avariable%20name%3d%22RRP%22%20%2f%3e%20%3e%200" encoding="perl" >
<br>
<actinic:block php="true" encoding="perl" >
$rrpprice = <actinic:variable name="RRP" />;
$price = <actinic:variable name="ProductPriceRaw" selectable="false" />;
{
$amountsaved = ($rrpprice - $price);
$savepercent = ((($rrpprice - $price) / $rrpprice) * 100);
echo "you save £$amountsaved";
echo " (".number_format($savepercent,1);
echo "%)";
}
</actinic:block>
</font>
</actinic:block>

[leehack]

[SpecTech]

how would I add it too the variable?

[Duncan Rounding]

Try this:

<actinic:block php="true" >
$rrp = <actinic:variable name="Product RRP" selectable="false" encoding="perl" />;
$rawprice = <actinic:variable name="ProductPriceRaw" selectable="false" encoding="perl" />;
{
$amountsaved = ($rrp - $rawprice);
$savepercent = ((($rrp - $rawprice) / $rrp) * 100);
echo "you save £$amountsaved";
echo " (".number_format($savepercent,1);
echo "%)";
}
</actinic:block>

[SpecTech]

Dont worry got it:

<actinic:variable encoding="perl" name="RRP" />

however still not working, this is odd as when I preview with the variable it works fine with no errors, maybe an actinic problem? I have compacted the database but still nothing.

[SpecTech]

Try this:

<actinic:block php="true" >
$rrp = <actinic:variable name="Product RRP" selectable="false" encoding="perl" />;
$rawprice = <actinic:variable name="ProductPriceRaw" selectable="false" encoding="perl" />;
{
$amountsaved = ($rrp - $rawprice);
$savepercent = ((($rrp - $rawprice) / $rrp) * 100);
echo "you save £$amountsaved";
echo " (".number_format($savepercent,1);
echo "%)";
}
</actinic:block>

Legend that worked

[Duncan Rounding]

I added encoding="perl" to the two variables as Norman mentioned.