Announcement

**Mike Hughes** · 12-Jul-2005, 12:37 PM

It might be because the table isn't 'right'. i.e. you define cols=3 but there are no <tr><td> tags within the table.

Try putting <tr><td colspan=3></td></tr> within the table tags and see if it then validates.

Mike

Edit: put the colspan in the wrong place. Now corrected.

**wjcampbe** · 12-Jul-2005, 12:40 PM

Myles,
I believe you can solve this by changing this

to this

or this

I read the 'not finished' as validator speak for table appears empty, because the only thing in it is not a valid html tag.

**pinbrook** · 12-Jul-2005, 12:40 PM

I have a feeling that your questions about the form tags is tied up with the validation errors - to me this thread is relevant

http://community.actinic.com/showthread.php?t=14962

**magicalwonders** · 12-Jul-2005, 01:15 PM

Thanks for the leads. I'll give these solutions a try.

I really don't think the form tags are the culprit here Jo. The code for the Act_CatalogBody appears to be wrong. It starts off with a closing tag </form> for the first form and no closing tag for the second. This can't be right.

I've corrected these errors and the forms now validate. I know that Actinic merges templates to generate finished code when uploaded, but surely the code within each template must follow the rules? If I'm wrong, an example of incorrect coding within a template becoming correct on the finished page would be appreciated.

Myles

**magicalwonders** · 12-Jul-2005, 02:23 PM

Try putting <tr><td colspan=3></td></tr> within the table tags and see if it then validates.

Excellent, this seems to work very nicely. Many thanks for your help on this. Am now down to seven errors on the catalog/index page. Haven't started on the products page yet, but I know the errors have reduced as a result of the work so far.

Thanks again.

Myles

**magicalwonders** · 13-Jul-2005, 03:28 PM

I've decided to take a break from the catalog/index and have a crack at the products page at this url: I've not given up on the index page, I just want to clear up the incorrect tags issue first.

http://www.magicalwonders.com/acatal..._Products.html

This page is producing 24 errors with only four of them involving tags. W3C have reported the following:

Line 16, column 70: document type does not allow element "TR" here
...NAME" VALUE="Basic_Products.html"><tr><td rowspan="2" valign="TOP" align="CEN

Line 16, column 869: document type does not allow element "TR" here
...ass="actxsmall"> </span></td></tr><tr><td align="LEFT" colspan="2"><span clas

Line 19, column 70: document type does not allow element "TR" here
...NAME" VALUE="Basic_Products.html"><tr><td rowspan="2" valign="TOP" align="CEN

Line 19, column 815: document type does not allow element "TR" here
...ass="actxsmall"> </span></td></tr><tr><td align="LEFT" colspan="2"><span clas

I believe I have tracked these issues down to two templates. Act_ProductPrice and ActProductLine. It took me quite a while to identify the templates involved, (99% sure it's these two) but unfortunately I'm not too sure what the remedy might be.

Anyone have any ideas on this one?

Myles

**wjcampbe** · 13-Jul-2005, 05:52 PM

Looks to me as if the problem is the whole <FORM></FORM> should be within one cell, and you don't close the opening <td tag or have a closing </td> after the </FORM>

<tr><td colspan=3 <Actinic:SECTION BLOB="A0002.cat"/> <FORM METHOD=POST ACTION="http://www.magicalwonders.com/cgi-bin/ca000001.pl" ><INPUT TYPE=HIDDEN NAME="SID" VALUE="2">
<INPUT TYPE=HIDDEN NAME="PAGE" VALUE="PRODUCT">
<INPUT TYPE=HIDDEN NAME="PAGEFILENAME" VALUE="Basic_Products.html"><tr><td rowspan="2" valign="TOP" align="CENTER"> <IMG SRC="x-calculator.gif" ALT="Calculator" BORDER=0 HEIGHT=134 WIDTH=151 > </td><td valign="TOP" align="LEFT" colspan="2"> <a name="a5"><span class="actregular"><b>Calculator</b></span></a><span class="actxsmall"> <br> This calculator features two-way power - using both batteries and solar power. </span><br><span class="actxsmall"> <Actinic:PRICE_EXPLANATION PROD_REF="5" COMPONENTID=-1></Actinic:PRICE_EXPLANATION> </span><br><b><Actinic:PRICES PROD_REF="5" RETAIL_PRICE_PROMPT="Price:"><br><span class="actxsmall"><b> Price:   £8.51</b></span><span class="actxxsmall"></span></Actinic:PRICES></b><br><span class="actxsmall"> </span><span class="actxsmall"> </span><span class="actxsmall"> </span></td></tr><tr><td align="LEFT" colspan="2"><span class="actxsmall"> <Actinic:CartError ProdRef="5"/><SPAN CLASS="actrequiredcolor"><BR>Quantity:</SPAN><INPUT TYPE=text NAME="Q_5" SIZE="4" VALUE="1"><br><Actinic:ACTIONS><P><INPUT TYPE=SUBMIT VALUE="Add To Cart" NAME="5"></P></Actinic:ACTIONS></span> </td></tr> </FORM>
<TR><TD

**magicalwonders** · 13-Jul-2005, 06:44 PM

I don't understand why it's getting messed up.

The netquotevar: Bulk is contained within one cell in the act_primary

<TR>
<TD align="center" width=550>
NETQUOTEVAR:FORMBEGIN
<A name=top><INPUT type=hidden value=NETQUOTEVAR:RANDOM name=RANDOM></A>
NETQUOTEVAR:HIDDENFIELDS
NETQUOTEVAR:BULK
NETQUOTEVAR:FORMEND</TD></TR>

The Netquotevar: Productbulk is contained within a cell in the Act_productbody O.K.

The two forms from the Act_Catalogbody seem to be O.K.

<FORM METHOD="POST" ACTION="NETQUOTEVAR:SEARCHCGIURL">
<INPUT TYPE=HIDDEN NAME="SHOP" VALUE="NETQUOTEVAR:SHOP">
NETQUOTEVAR:SEARCHBODY
</FORM>
<FORM METHOD=NETQUOTEVAR:CGIMETHOD ACTION="NETQUOTEVAR:CGIURL">
<INPUT TYPE=HIDDEN NAME="SHOP" VALUE="NETQUOTEVAR:SHOP">
NETQUOTEVAR: DESITEMAPLINK
</FORM>

The only alteration I've made here is to move the closing tag </form> from its original position at the top of the form to the bottom. There are no other tags in this template.

So although everything looks O.K. in the individual templates, when it gets uploaded, it all goes to rat do do.

Any ideas?

**pinbrook** · 13-Jul-2005, 06:47 PM

you can't just move <form > tags around

By moving the tag from the top to the bottom of the template you have made the other form on the page a nested form rather than close one form amd then begin another

**magicalwonders** · 13-Jul-2005, 07:02 PM

I'm really missing something here.

This is the original code:

</FORM>
< FORM METHOD="POST" ACTION="NETQUOTEVAR:SEARCHCGIURL">
<INPUT TYPE=HIDDEN NAME="SHOP" VALUE="NETQUOTEVAR:SHOP">
NETQUOTEVAR:SEARCHBODY
</FORM>
<FORM METHOD=NETQUOTEVAR:CGIMETHOD ACTION="NETQUOTEVAR:CGIURL">
<INPUT TYPE=HIDDEN NAME="SHOP" VALUE="NETQUOTEVAR:SHOP">
NETQUOTEVAR: DESITEMAPLINK

The first form starts with a closing tag </FORM> followed by an opening tag <FORM...
The second form has no closing tag. How does this work?

Confused.

**magicalwonders** · 13-Jul-2005, 07:07 PM

Hold the phone...........You're talking about the form in the Act_primary getting messed up yes?

**magicalwonders** · 13-Jul-2005, 07:31 PM

Mmmmm, Well I put the tag back where it was and got three extra errors as a result.

Line 16, column 238: end tag for element "FORM" which is not open
...EVAR:RANDOM name=RANDOM></A> </FORM><FORM METHOD="POST" ACTION="http://www.

Line 16, column 801: end tag for "FORM" omitted, but its declaration does not permit this
...nbottom"> </A></DIV> </TD></TR><TR><TD align=right>Next/Prev link

Line 16, column 366: start tag was here
...=HIDDEN NAME="SHOP" VALUE=""> </FORM><FORM METHOD=POST ACTION="http://www.mag

Somebody help me from going bonkers!

Myles

**wjcampbe** · 13-Jul-2005, 07:33 PM

To get an answer to that question, you need to turn OFF Compact HTML/CGI and then we will see the template names above the section of code generated by each template.

**pinbrook** · 13-Jul-2005, 08:44 PM

The issue here to understand is just because code is valid it isn't necessarily logical and thus work.

The template in question starts with a </FORM> because its matching <FORM> is in a different template.

Subsequently the other <FORM> tag on that page also has its </FORM> elsewhere.

The only code you can validate is the resulting code you get when the site is uploaded. During the upload process all the templates get put together to create the HTML pages and thus the FORM tags become paired. TABLE tags get paired etc also.

It will help if you upload your site with uncompacted code, this way you will be able to see the tags and the templates which generate them.

Whilst you have uncompacted code you will also get W3C errors but you will have to ignore these - when the exercise in complete you will turn off compacting and the errors will disapear.

There are a few errors you can eradicate by moving bits of code into CSS.

If you move <TABLE> and </TABLE> tags or <FORM> and </FORM> tags you will end up with a non functioning site. You could search the forums to see people with non functioning pieces of code to see that the solution is to put the FORM code back in place. (Some people have inadvertantly removed a tag)

An Actinic site is never going to validate, all you can do is clean up bits and bobs to improve it.

**magicalwonders** · 13-Jul-2005, 11:24 PM

Yes, I've been turning off the compacted code to get at the various templates and I understand that I'll never get the site to validate 100%

However, it should be possible to get rid of <TR> errors and <DIV> problems along with a lot of other stuff.

In an effort to really simplify the code (to see the wood for the trees) I have made an Act_primary consisting of One table, three rows and three columns. I've reverted to original Actinic code and commented most of the Netquotevars.

The code this produces on the index page is as follows:

<A HREF="P_home.html" TARGET="_parent" onMouseOver="SwapImage('hnavb_home','../home2.gif')" onMouseOut="RestoreImage()">Home</A> <A HREF="P_info.html" TARGET="_self"
onMouseOver="SwapImage('hnavb_info','../info2.gif')" onMouseOut="RestoreImage()">Terms of Business</A> <A HREF="../../../Act_PreviewWarningPage.html?ACTION=SHOWCART" TARGET="_self"
onMouseOver="SwapImage('hnavb_cart','../cart2.gif')" onMouseOut="RestoreImage()">View Basket</A> <A HREF="../../../Act_PreviewWarningPage.html?ACTION=Start" TARGET="_self" onMouseOver="SwapImage
('hnavb_checkout','../order2.gif')" onMouseOut="RestoreImage()">Checkout</A> </TD><TD class=tdback width=130>  </TD></TR><TR><TD class=tdback><TABLE width="100%"><TR><TD WIDTH="100%" valign="top">
<A HREF="Basic_Products.html"><span class="actxsmall">Basic Products</span></A> </TD>
</TR></TABLE>
<TABLE width="100%"><TR><TD WIDTH="100%" valign="top">
<A HREF="More_Products.html"><span class="actxsmall">More Stuff</span></A> </TD>
</TR></TABLE>
</TD><TD align="center" width=550> <A name=top><INPUT type=hidden value=NETQUOTEVAR:RANDOM name=RANDOM></A> <FORM METHOD="POST" ACTION="../../../Act_PreviewWarningPage.html">
<INPUT TYPE=HIDDEN NAME="SHOP" VALUE=""> </FORM><FORM METHOD=GET ACTION="../../../Act_PreviewWarningPage.html"><INPUT TYPE=HIDDEN NAME="SHOP" VALUE=""> </FORM> <A NAME="sectiontop"><DIV ALIGN="CENTER"> </DIV>
<Actinic:CartError_List/></A> <BR><TABLE WIDTH="500" COLS="3" BORDER="0" CELLPADDING="10" CELLSPACING="0" ALIGN="CENTER"> <Actinic:SECTION BLOB="A0000.cat"/></TABLE><A NAME="sectionbottom"><DIV ALIGN="RIGHT"> </DIV>
<DIV ALIGN="CENTER"> </DIV></A> </TD><TD class=tdback></TD></TR></TABLE></BODY></HTML>

17th Line down is a closing </Table> tag. This is followed by a closing </TD> which is obviously wrong. The unpacted code for that part of the page shows as follows:

<Actinic:TEMPLATE type="end" filename="C:\Program Files\Actinic v7\Sites\Site1\Act_SectionLineSmallText.html"/><Actinic:TEMPLATE type="begin" filename="C:\Program Files\Actinic v7\Sites\Site1\Act_SectionLineSmallText.html"/>



<A HREF="More_Products.html"><span class="actxsmall">More Stuff</span></A>
</TD>
</TR></TABLE>
</TD>
<TD align="center" width=550>

The act_sectionlineSmallText template has no <TR> or <TD> code. So it's not clear how this </TD> is getting generated.

If I can get rid of <TR> <TD> and preferably <form> errors, I reckon I might be able to live with any other stuff I can't fix.

This is one of the problems of being a "glass half full" person.....We live in hope!

Myles

Announcement

Starting Again!

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment

Comment